-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[--output-format json|--output-format json] format becomes [--output-yaml|--output-json] #523
Conversation
@@ -1164,7 +1164,7 @@ Usage: cardano-cli shelley transaction txid | |||
|
|||
Print a transaction identifier. | |||
|
|||
Usage: cardano-cli shelley transaction view [--output-format STRING] | |||
Usage: cardano-cli shelley transaction view [--json | --yaml] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we should prefix those formats with output
or similar keyword e.g. --output-json
. It would be better to logically group them together in case we would like to add new output formats in the future e.g. cbor, bson, messagepack, xml...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In response to your question --as-json | --as-yaml
? It reads well however you can prepend output instead if you think that is preferable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I prefer the shorter flags, but no strong opinion. @Jimbo4350> what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK so went for --output-json
and --output-yaml
after seeing @Jimbo4350's similar opinion below 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep that's fine 👍
1f7897e
to
87db026
Compare
@@ -1164,7 +1164,7 @@ Usage: cardano-cli shelley transaction txid | |||
|
|||
Print a transaction identifier. | |||
|
|||
Usage: cardano-cli shelley transaction view [--output-format STRING] | |||
Usage: cardano-cli shelley transaction view [--json | --yaml] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In response to your question --as-json | --as-yaml
? It reads well however you can prepend output instead if you think that is preferable.
87db026
to
7bb38c3
Compare
Warning
In addition to changing
governance
commands, I changed the behavior oftransaction view
too; to be consistent.If we don't want to change
transaction view
(which is a historical command right?), LMK I will revert this part of the change.Changelog
Context
--output-format
, like other commands, instead of--yaml
#521--output-format
, like other commands, instead of--yaml
#521 (comment)How to trust this PR
Look at the diff of golden files
Checklist