Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invalid options on cardano-cli babbage transaction build and build-raw #520

Merged
merged 2 commits into from
Dec 13, 2023
Merged

fix: invalid options on cardano-cli babbage transaction build and build-raw #520

merged 2 commits into from
Dec 13, 2023

Conversation

felix-lipski
Copy link
Contributor

@felix-lipski felix-lipski commented Dec 13, 2023 •
edited
Loading

Changelog

- description: |
    split eras in transaction build
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

cardano-cli babbage transaction build AND build-raw show invalid options

How to trust this PR

Run cardano-cli <pre-conway> transaction build/build-raw - it now doesn't show the --vote-file and --proposal-file flags.
Run cardano-cli conway transaction build/build-raw - it still shows the --vote-file and --proposal-file flags.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@felix-lipski felix-lipski changed the title Felix lipski/txn build invalid file options txn build invalid file options Dec 13, 2023
@felix-lipski felix-lipski changed the title txn build invalid file options cardano-cli babbage transaction build AND build-raw show invalid options Dec 13, 2023
@felix-lipski felix-lipski changed the title cardano-cli babbage transaction build AND build-raw show invalid options fix: invalid options on cardano-cli babbage transaction build and build-raw Dec 13, 2023
@felix-lipski
Copy link
Contributor Author

As per: #504 (comment), I have only modified the era based commands, and not the legacy commands.

@felix-lipski felix-lipski marked this pull request as ready for review December 13, 2023 13:10
carlhammann
carlhammann approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@carlhammann carlhammann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, and props for using VoteFile instead of File!

cardano-cli/src/Cardano/CLI/EraBased/Options/Transaction.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/EraBased/Options/Transaction.hs Outdated Show resolved Hide resolved
@felix-lipski
split eras in transaction build
73def6c 
split eras in build raw

update goldens

change to plural pNames
@felix-lipski felix-lipski force-pushed the felix-lipski/txn-build-invalid-file-options branch from b0ff319 to 73def6c Compare December 13, 2023 16:40
@felix-lipski felix-lipski linked an issue Dec 13, 2023 that may be closed by this pull request
cardano-cli babbage transaction build AND build-raw show invalid options #502
Closed
@felix-lipski felix-lipski added this pull request to the merge queue Dec 13, 2023
Merged via the queue into main with commit c7f1e95 Dec 13, 2023
22 checks passed
@felix-lipski felix-lipski deleted the felix-lipski/txn-build-invalid-file-options branch December 13, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlhammann carlhammann carlhammann approved these changes

@carbolymer carbolymer carbolymer approved these changes

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@newhoggy newhoggy Awaiting requested review from newhoggy

@kevinhammond kevinhammond Awaiting requested review from kevinhammond

@disassembler disassembler Awaiting requested review from disassembler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cardano-cli babbage transaction build AND build-raw show invalid options
3 participants
@felix-lipski @carbolymer @carlhammann