-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create-staked: add test #498
Conversation
c36e980
to
95ca168
Compare
tree root = do | ||
-- listDirectory returns a path relative to 'root'. We need to prepend | ||
-- root to it for queries below. | ||
content <- map (root </>) <$> listDirectory root |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the order of the files? If listDirectory
does not give us any order
guarantees, it would be nice to sort the list to have consistency between filesystems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carbolymer> actually it's the caller that postprocesses the result of tree
to make it stable, along with normalization and making it relative (to avoid depending on a temporary directory name) 👍
|
||
import Cardano.Api.Shelley (ShelleyGenesis (sgNetworkMagic, sgStaking)) | ||
|
||
import Cardano.Ledger.Crypto (StandardCrypto) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StandardCrypto
is exposed via Cardano.Api.Ledger
. If you find yourself reaching for things directly from the ledger repo, check that it's not already exposed via Cardano.Api.Ledger
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to this @Jimbo4350, I could avoid adding a dependency to cardano-ledger-core
! Good catch 🙏
95ca168
to
07813a5
Compare
07813a5
to
a2d1b0b
Compare
Changelog
Context
genesis.json
file.create-testenet-data
(Add create-testnet-data command #488)How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist