Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use selectStakeCredentialWitness instead of duplicating credential selection #476

Merged

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Nov 22, 2023

Changelog

- description: |
    Use `selectStakeCredentialWitness` instead of duplicating credential selection
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
   - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
   - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This PR requires:

Fixes:

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/fix/mgalazyn/fix/use-only-stake-creds-for-witnesses branch 8 times, most recently from 7a044f0 to d06eb5d Compare November 23, 2023 17:36
@carbolymer carbolymer changed the title Mgalazyn/fix/mgalazyn/fix/use only stake creds for witnesses Use selectStakeCredentialWitness instead of duplicating credential selection Nov 23, 2023
@carbolymer carbolymer force-pushed the mgalazyn/fix/mgalazyn/fix/use-only-stake-creds-for-witnesses branch 3 times, most recently from e7e6790 to 7665fc7 Compare November 24, 2023 10:35
@carbolymer carbolymer marked this pull request as ready for review November 24, 2023 10:36
@carbolymer carbolymer force-pushed the mgalazyn/fix/mgalazyn/fix/use-only-stake-creds-for-witnesses branch from 7665fc7 to a1acc61 Compare November 24, 2023 10:46
@carbolymer carbolymer added this pull request to the merge queue Nov 24, 2023
Merged via the queue into main with commit c50683f Nov 24, 2023
20 checks passed
@carbolymer carbolymer deleted the mgalazyn/fix/mgalazyn/fix/use-only-stake-creds-for-witnesses branch November 24, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants