Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of stake pool keys as credentials #412

Closed
wants to merge 1 commit into from

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Oct 30, 2023

Changelog

- description: |
    Removes usage of stake pool keys as credentials
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
   - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
   - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This PR removes usage of stake pool keys as credentials. This also removes coercing of the keys types in the code.

The context for the change: https://input-output-rnd.slack.com/archives/G011N23CEAE/p1698227871191609

Requires:

This PR requres IntersectMBO/cardano-api#341 to compile. To be merged after merging of the required PR in API.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/fix/remove-keys-coercing branch from 37265b1 to e7e0cb2 Compare October 30, 2023 17:30
@carbolymer carbolymer changed the title Remove keys coercing Remove usage of stake pool keys as credentials Oct 30, 2023
@carbolymer carbolymer force-pushed the mgalazyn/fix/remove-keys-coercing branch from e7e0cb2 to 16b46af Compare October 30, 2023 17:38
@carbolymer carbolymer marked this pull request as ready for review October 30, 2023 17:39
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore this

@Jimbo4350 Jimbo4350 self-requested a review October 31, 2023 13:16
@carbolymer carbolymer force-pushed the mgalazyn/fix/remove-keys-coercing branch from 16b46af to 4e97da7 Compare November 2, 2023 15:56
@carbolymer carbolymer mentioned this pull request Nov 2, 2023
4 tasks
@carbolymer
Copy link
Contributor Author

Superceded by: #430

@carbolymer carbolymer closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants