Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to cardano-api-8.23.1.0 #320

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Sep 29, 2023

Changelog

- description: |
    Update to `cardano-api-8.23.1.0`
# uncomment types applicable to the change:
  type:
   - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
   - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Requires to build a new release of cadano-api which includes:

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@@ -200,7 +200,7 @@ library
, binary
, bytestring
, canonical-json
, cardano-api ^>= 8.22
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO:

  • use 8.24 after release
  • bump flake.lock
  • bump chap index in cabal.project

<*> ppDRepActivity

ppDRepActivity :: Parser (StrictMaybe EpochNo)
ppDRepActivity = pure SNothing -- TODO Conway
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO Parsers are stubbed to make changes smaller. To be implemented in the next PR.

@carbolymer
Copy link
Contributor Author

carbolymer commented Sep 29, 2023

Build fails currently because it requires unreleased cardano-api changes. To be fixed prior to merge.

@newhoggy newhoggy changed the title Update to cardano-api 8.24 Update to cardano-api-8.23.1.0 Oct 2, 2023
@newhoggy newhoggy force-pushed the mgalazyn/feature/update-to-cardano-api-8.24 branch from ac54552 to 5cc2922 Compare October 2, 2023 01:36
@newhoggy newhoggy requested review from a team as code owners October 2, 2023 01:36
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sold on AnyEraInEon

@Jimbo4350 Jimbo4350 self-requested a review October 2, 2023 13:31
@newhoggy newhoggy dismissed Jimbo4350’s stale review October 2, 2023 13:32

Comments addressed

@newhoggy
Copy link
Contributor

newhoggy commented Oct 2, 2023

As agreed, AnyEraInEon will be renamed to EraInEon in a future PR.

@newhoggy newhoggy added this pull request to the merge queue Oct 2, 2023
@newhoggy newhoggy mentioned this pull request Oct 2, 2023
10 tasks
Merged via the queue into main with commit 1a140f5 Oct 2, 2023
@newhoggy newhoggy deleted the mgalazyn/feature/update-to-cardano-api-8.24 branch October 2, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants