Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --conway-era flag #276

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Remove --conway-era flag #276

merged 1 commit into from
Sep 14, 2023

Conversation

newhoggy
Copy link
Contributor

Changelog

- description: |
    Remove `--conway-era` flag
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

From Conway era onwards, era flags will no longer be used. Era-based command should be used instead.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as ready for review September 14, 2023 05:01
@carbolymer
Copy link
Contributor

I think 41c4e8f commit is not from this PR

@newhoggy newhoggy added this pull request to the merge queue Sep 14, 2023
@newhoggy newhoggy removed this pull request from the merge queue due to a manual request Sep 14, 2023
@newhoggy newhoggy force-pushed the newhoggy/remove-conway-era-flag branch from 795d9f9 to d4b93c7 Compare September 14, 2023 10:29
@newhoggy newhoggy enabled auto-merge September 14, 2023 10:30
@newhoggy newhoggy added this pull request to the merge queue Sep 14, 2023
Merged via the queue into main with commit 5a0cc14 Sep 14, 2023
19 checks passed
@newhoggy newhoggy deleted the newhoggy/remove-conway-era-flag branch September 14, 2023 11:17
@@ -1412,3 +1413,39 @@ pStakePoolDeregistrationCertificateCmd envCli =
<*> pStakePoolVerificationKeyOrFile
<*> pEpochNo "The epoch number."
<*> pOutputFile

pLegacyCardanoEra :: EnvCli -> Parser AnyCardanoEra
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

amesgen added a commit to IntersectMBO/cardano-node that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants