-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Shelley
prefix on from errors
#262
Conversation
b9afe78
to
5742c6e
Compare
| GenesisCmdGenesisFileDecodeError !FilePath !Text | ||
| GenesisCmdGenesisFileError !(FileError ()) | ||
| GenesisCmdFileError !(FileError ()) | ||
| GenesisCmdMismatchedGenesisKeyFiles [Int] [Int] [Int] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GenesisCmdMismatchedGenesisKeyFiles
is in desperate need of commentary
@@ -0,0 +1,14 @@ | |||
module Cardano.CLI.Types.Errors.AddressInfoError |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need a separate module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put it separate from the command error because I think command errors should be separate from domain errors. I'm wondering if we should have a separate parent module for command errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging now. Can refactor later.
5742c6e
to
9912955
Compare
9912955
to
33fa8a1
Compare
Changelog
Context
Remove
Shelley
prefix from error types and constructors. Pretty much all code going forward is going to be Shelley based. TheShelley
prefix is redundant because there isn't a need to distinguish it from anything else.Checklist
See Running tests for more details
.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7