Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to cardano-api-8.19 #209

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Aug 24, 2023

Changelog

- description: |
    Update to `cardano-api-8.19`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Requires:

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@Jimbo4350 Jimbo4350 force-pushed the jordan/bump-chap-for-cardano-api branch 4 times, most recently from 9812b53 to 635d040 Compare August 28, 2023 19:19
@carbolymer carbolymer force-pushed the jordan/bump-chap-for-cardano-api branch from 635d040 to fcc57b6 Compare August 30, 2023 16:57
@carbolymer carbolymer marked this pull request as draft August 30, 2023 16:58
@carbolymer carbolymer force-pushed the jordan/bump-chap-for-cardano-api branch 2 times, most recently from 8d77e2d to bb878d4 Compare August 30, 2023 17:02
@carbolymer carbolymer force-pushed the jordan/bump-chap-for-cardano-api branch from bb878d4 to c91ce8f Compare August 30, 2023 18:29
@carbolymer carbolymer changed the title WIP: Bump CHaP for cardano-api Update cardano-api 8.18 Aug 30, 2023
@carbolymer carbolymer marked this pull request as ready for review August 30, 2023 18:29
@carbolymer carbolymer changed the title Update cardano-api 8.18 Update cardano-api to 8.18 Aug 30, 2023
@carbolymer carbolymer force-pushed the jordan/bump-chap-for-cardano-api branch from c91ce8f to c0bff98 Compare August 30, 2023 18:35
@carbolymer carbolymer force-pushed the jordan/bump-chap-for-cardano-api branch from c0bff98 to 8a313a7 Compare August 30, 2023 18:41
@carbolymer carbolymer requested review from a team as code owners August 30, 2023 18:41
@coot
Copy link
Contributor

coot commented Sep 1, 2023

The CI fails when running ghc-9.6:

 <no location info>: error: [GHC-42258] [-Wunused-packages, Werror=unused-packages]
    The following packages were specified via -package or -package-id flags,
    but were not needed for compilation:
      - cardano-protocol-tpraos-1.0.3.4 (exposed by flag -package-id cardano-protocol-tpraos-1.0.3.4-0ed04b137b01e0406514c6d5a9b4cf4038b1522e2aa1a34c5e5cc55e00acb24c)

@carbolymer carbolymer force-pushed the jordan/bump-chap-for-cardano-api branch from 8a313a7 to 2168a0c Compare September 4, 2023 17:15
@carbolymer carbolymer changed the title Update cardano-api to 8.18 Update cardano-api to 8.19 Sep 4, 2023
@carbolymer carbolymer force-pushed the jordan/bump-chap-for-cardano-api branch 3 times, most recently from ca7cbae to 77b29e5 Compare September 5, 2023 12:22
ShelleyBasedEraMary -> Nothing
ShelleyBasedEraAlonzo -> Just $ pp ^. Ledger.ppPricesL
ShelleyBasedEraBabbage -> Just $ pp ^. Ledger.ppPricesL
ShelleyBasedEraConway -> Just $ pp ^. Ledger.ppPricesL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we had AlonzoEraOnwards we could use that here instead of matching on every shelley based era.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be done in a follow up PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe John has a PR with that.

@newhoggy newhoggy changed the title Update cardano-api to 8.19 Update to cardano-api-8.19 Sep 5, 2023
@carbolymer carbolymer force-pushed the jordan/bump-chap-for-cardano-api branch from 77b29e5 to 67973c8 Compare September 5, 2023 14:59
@@ -546,25 +555,26 @@ runTxBuild
& onLeft (left . ShelleyTxCmdQueryConvenienceError . AcqFailure)
& onLeft (left . ShelleyTxCmdQueryConvenienceError . QceUnsupportedNtcVersion)

Refl <- testEquality era nodeEra
& hoistMaybe (ShelleyTxCmdTxEraCastErr $ EraCastError ("nodeEra" :: Text) era nodeEra)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the error rendering of ShelleyTxCmdTxEraCastErr to basically say the cli must produce transactions that are of the same era as the node. This can be done in a follow up PR.

@carbolymer carbolymer force-pushed the jordan/bump-chap-for-cardano-api branch from 67973c8 to d2cb99a Compare September 6, 2023 08:31
@carbolymer carbolymer force-pushed the jordan/bump-chap-for-cardano-api branch from d2cb99a to 23b7bbf Compare September 6, 2023 09:18
@carbolymer carbolymer added this pull request to the merge queue Sep 6, 2023
Merged via the queue into main with commit 509004a Sep 6, 2023
@carbolymer carbolymer deleted the jordan/bump-chap-for-cardano-api branch September 6, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants