-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to cardano-api-8.19
#209
Conversation
9812b53
to
635d040
Compare
635d040
to
fcc57b6
Compare
8d77e2d
to
bb878d4
Compare
bb878d4
to
c91ce8f
Compare
c91ce8f
to
c0bff98
Compare
c0bff98
to
8a313a7
Compare
The CI fails when running
|
8a313a7
to
2168a0c
Compare
ca7cbae
to
77b29e5
Compare
ShelleyBasedEraMary -> Nothing | ||
ShelleyBasedEraAlonzo -> Just $ pp ^. Ledger.ppPricesL | ||
ShelleyBasedEraBabbage -> Just $ pp ^. Ledger.ppPricesL | ||
ShelleyBasedEraConway -> Just $ pp ^. Ledger.ppPricesL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we had AlonzoEraOnwards
we could use that here instead of matching on every shelley based era.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be done in a follow up PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe John has a PR with that.
77b29e5
to
67973c8
Compare
@@ -546,25 +555,26 @@ runTxBuild | |||
& onLeft (left . ShelleyTxCmdQueryConvenienceError . AcqFailure) | |||
& onLeft (left . ShelleyTxCmdQueryConvenienceError . QceUnsupportedNtcVersion) | |||
|
|||
Refl <- testEquality era nodeEra | |||
& hoistMaybe (ShelleyTxCmdTxEraCastErr $ EraCastError ("nodeEra" :: Text) era nodeEra) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update the error rendering of ShelleyTxCmdTxEraCastErr
to basically say the cli must produce transactions that are of the same era as the node. This can be done in a follow up PR.
67973c8
to
d2cb99a
Compare
d2cb99a
to
23b7bbf
Compare
Changelog
Context
Requires:
Checklist
See Running tests for more details
.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7