Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove upper bound on vector. Fix #327 #416

Merged
merged 1 commit into from
May 24, 2023
Merged

Remove upper bound on vector. Fix #327 #416

merged 1 commit into from
May 24, 2023

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented May 19, 2023 •
edited
Loading

New version of nothunks have been released that no longer poses a problem

@lehins lehins requested a review from andreabedini May 23, 2023 18:37
andreabedini
andreabedini approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@andreabedini andreabedini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andreabedini andreabedini merged commit a344b32 into master May 24, 2023
@andreabedini andreabedini deleted the lehins/remove-upper-bound branch May 24, 2023 06:09
@andreabedini andreabedini self-assigned this May 24, 2023
@michaelpj
Copy link
Contributor

Perhaps this should have also put a lower bound on the nothunks version?

@lehins
Copy link
Collaborator Author

lehins commented May 24, 2023 •
edited
Loading

@michaelpj No need. Bad version of nothunks was disabled: input-output-hk/nothunks#17 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreabedini andreabedini andreabedini approved these changes

Assignees

@andreabedini andreabedini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lehins @michaelpj @andreabedini