-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest cabal master for haddocks generation. Fix broken haddocks. #577
Conversation
66748ce
to
dca8b6e
Compare
dca8b6e
to
724dd3e
Compare
@@ -43,7 +43,7 @@ jobs: | |||
- name: Build documentation | |||
run: | | |||
nix develop .\#haddockShell --command \ | |||
cabal haddock-project --local --output=./haddocks --internal --foreign-libraries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why remove --local
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command line argument is not present anymore in the latest cabal master.
@carbolymer> can we test the behavior before merging? (building locally?) |
@smelc I've enabled for the development the workflow on a branch, and you can see the results there: https://github.com/IntersectMBO/cardano-api/actions/runs/9778593657 |
CI is green, so force merging. |
Changelog
Context
Use latest cabal master for haddocks generation.
Fixes #437
Fixes #546
Sample workflow run with generated haddocks: https://github.com/IntersectMBO/cardano-api/actions/runs/9778593657
Checklist