Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable deposit return scripts and constitutional scripts #456

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Feb 15, 2024

Changelog

- description: |
    Enable deposit return script addresses
    Enable constitutional scripts
 
  type:
  - bugfix         # fixes a defect
  - compatible     # the API has changed but is non-breaking
  - feature

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@Jimbo4350 Jimbo4350 changed the title Implemenet and expose getScriptCredential Implement and expose getScriptCredential Feb 15, 2024
@Jimbo4350 Jimbo4350 force-pushed the jordan/implement-getScriptCredential branch 4 times, most recently from c16e8d2 to d9214b7 Compare February 15, 2024 16:47
@Jimbo4350 Jimbo4350 changed the title Implement and expose getScriptCredential Update selectStakeCredentialWitness to return all possible Credentials Feb 15, 2024
@carbolymer
Copy link
Contributor

This PR appears to be reverting fix for ExtraRedeemers error: IntersectMBO/cardano-cli#297 (comment) , meaning this PR: https://github.com/IntersectMBO/cardano-api/pull/383/files . However, that was for babbage era but this PR is in Conway. It would be worth running a similar regression test but for Conway.

Can you check with @mkoura if it's not breaking test suites in https://github.com/IntersectMBO/cardano-node-tests ?

Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this PR. I'm approving to not block development, on a condition that you test that it's not causing any regressions: #456 (comment)

@Jimbo4350 Jimbo4350 changed the title Update selectStakeCredentialWitness to return all possible Credentials Enable certifying and proposing plutus scripts Feb 15, 2024
@Jimbo4350 Jimbo4350 changed the title Enable certifying and proposing plutus scripts DO NOT MERGE: Enable certifying and proposing plutus scripts Feb 19, 2024
@Jimbo4350 Jimbo4350 force-pushed the jordan/implement-getScriptCredential branch 6 times, most recently from d2018c0 to 4fafc3e Compare February 21, 2024 23:19
@Jimbo4350 Jimbo4350 changed the title DO NOT MERGE: Enable certifying and proposing plutus scripts Enable constitution scripts Feb 22, 2024
@Jimbo4350 Jimbo4350 changed the title Enable constitution scripts Enable deposit scripts and constitution scripts Feb 22, 2024
@Jimbo4350 Jimbo4350 changed the title Enable deposit scripts and constitution scripts Enable deposit return scripts and constitutional scripts Feb 22, 2024
@Jimbo4350 Jimbo4350 force-pushed the jordan/implement-getScriptCredential branch from 4fafc3e to 5ec37fc Compare February 23, 2024 00:17
@Jimbo4350 Jimbo4350 force-pushed the jordan/implement-getScriptCredential branch from 5ec37fc to 83c47ea Compare February 23, 2024 00:20
@Jimbo4350 Jimbo4350 enabled auto-merge February 23, 2024 00:20
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Feb 23, 2024
Merged via the queue into main with commit 68e4956 Feb 23, 2024
21 checks passed
@Jimbo4350 Jimbo4350 deleted the jordan/implement-getScriptCredential branch February 23, 2024 00:47
newhoggy pushed a commit that referenced this pull request Mar 11, 2024
…sit-value-mandatory-in-conway-era

Correct conway parser, so that --key-reg-deposit-amt is mandatory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants