Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Schema, Example, and Context Fixes #264

Merged

Conversation

sebbader-sap
Copy link
Contributor

No description provided.

@sebbader-sap sebbader-sap marked this pull request as ready for review May 17, 2024 04:46
@sebbader-sap sebbader-sap requested review from mkollenstart, juliapampus and jimmarino and removed request for juliapampus May 17, 2024 04:47
@sebbader-sap
Copy link
Contributor Author

@mkollenstart I need help to push the files into the releases folder. We have an Action for it, don't we?

@mkollenstart
Copy link
Member

No there isn't an action to create the release folder structure, since it also should be pushed in the repository.

So to create the release folder you need to execute the following commands and then push again:

rsync -Rav --prune-empty-dirs --exclude="releases/**" --include="*/" --include="**/*.json" --exclude="**" ./ ./releases/2024-1/
rsync -Rav --prune-empty-dirs --exclude="releases/**" --include="*/" --include="**/*.ttl" --exclude="**" ./ ./releases/2024-1/

But since this will overwrite the existing release folder, you have to remove the existing 2024-1 folder in releases before executing the rsync commands.

An other issue that will come up is the "Prevent Changes to Release Files" check that is executed, since this one will fail if files are modified in the releases folder. I'm not sure how we tackled that in the previous hotfix.

@sebbader-sap
Copy link
Contributor Author

So to create the release folder you need to execute the following commands and then push again:

Just did so

@sebbader-sap
Copy link
Contributor Author

An other issue that will come up is the "Prevent Changes to Release Files" check that is executed, since this one will fail if files are modified in the releases folder. I'm not sure how we tackled that in the previous hotfix.

I just opened #266 . Let's see if that "opens the door".

@ssteinbuss ssteinbuss merged commit 50f2a64 into International-Data-Spaces-Association:main Jun 19, 2024
1 check passed
@IgorBalog-Eng
Copy link

Nice work.
Still some small remarks, catalog and dataset have same ids (catalog.json and dataset.json, in example folder), and in catalog.json, dataset.id = policy.id
Could we use, for some future documentation, ids like urn:uuid:catalog_id_uuid, urn:uuid:dataset_id_uuid, and such?
Hoping this will not confuse readers to replace catalog_id_uuid with generated UUID. This way, we could use symbolic values for ids and reference them where needed.

2.1 Contract Request Message

Sent by Consumer
Resulting state REQUESTED, TERMINATED
Response ACK or ERROR
Schema TTL Shape, JSON Schema
Example Initiating Message, Message <---- THIS ONE here, offer
Message still points to contract offer message.

I will double check once again official version of documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants