-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with Royal Road version #34
Open
ThrawnCA
wants to merge
45
commits into
IntermittentlyRupert:master
Choose a base branch
from
ThrawnCA:royalroad-sync-2023-12
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sync with Royal Road version #34
ThrawnCA
wants to merge
45
commits into
IntermittentlyRupert:master
from
ThrawnCA:royalroad-sync-2023-12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ThrawnCA
commented
Nov 13, 2024
- Adjust spelling, grammar, punctuation, formatting, and line breaks to be closer to the Royal Road version when feasible, without reverting to actual errors.
- Apply fixes such as changing "alright" to "all right"
- Apply underlines using CSS instead of misusing the 'u' tag
- Use em-dashes more consistently
- Fix usage of italics on punctuation; include the punctuation if it's Parseltongue or internal monologue.
- Add italics to incantations
- Capitalise names like Restricted Section
- Use "autumn" (British) instead of "fall"
- Replace some hyphens with em-dashes - Add capitalisation to a word described as a 'shriek' - Drop some section breaks
- Replace some hyphens with em-dashes - Restore underlines that all other versions have
- Replace some hyphens with em-dashes - Add and remove section breaks to match other versions - Drop unnecessary commas before dialogue - Drop reference to 'Ogg' that other versions don't have - Adjust orientation of apostrophe in contraction
…fp-ebook into royalroad-sync-2023-12
- Replace some hyphens with em-dashes - Add and remove section breaks to match other versions - Restore underline that all other versions have - Disambiguate a repeated pronoun - Adjust punctuation order
- Replace some hyphens with em-dashes - Remove section breaks to match other versions
- Replace some hyphens with em-dashes - Remove section breaks to match other versions
- Add italics around 'Quidditch Through the Ages' title - Remove some section breaks
- Capitalise 'my' - Remove some section breaks
- Add italics to Goldfarb's letter - Remove some section breaks
- Most instances use 'all right', either is valid but it's best to be consistent.
- Remove some section breaks based on Royal Road version - Replace nested double quotes with single quotes
- Remove some section breaks based on Royal Road version
- Add and remove some section breaks based on Royal Road version - Add italics for incantations
- Remove some section breaks based on Royal Road version - Move full stops inside quotation marks - Undo some minor changes that weren't really essential, bring it back in line with the original
- Remove some section breaks based on Royal Road version - Add emphasis to spell name - Lowercase season name
- Eg in a title or at the start of a sentence
- Make commas italic when associated with Harry's all-italic internal thoughts, non-italic in most other cases such as after incantations.
- Remove some section breaks based on Royal Road version - Add emphasis to spell name - Replace repeated 'and' with comma
- Remove some section breaks based on Royal Road version - Restore capitals instead of italics for shouting - Adjust capitalisation
- Remove some section breaks based on Royal Road version - Make punctuation better match RR - Add emphasis to spell incantations - Avoid repeated 'and'
- Don't italicise punctuation if the preceding word was only italic because it was an incantation. But do italicise punctuation if the whole sentence is italic because it's Parseltongue or internal monologue, or if the preceding word is italicised for emphasis.
- Remove some section breaks and drop some commas in dialogue based on Royal Road version - Add emphasis to spell incantations - Convert hyphens between phrases to em dashes
- Remove some section breaks based on Royal Road version - Adjust grammar to be closer to RR - Convert hyphens between phrases to em dashes
- Remove some section breaks based on Royal Road version - Adjust grammar and punctuation to be closer to RR - Convert hyphens between phrases to em dashes - Italicise incantations - Lowercase 'godfather'
- Replace dashes between phrases with em dashes - Lowercase 'godfather'
- Remove some section breaks based on Royal Road version - Adjust grammar and punctuation to be closer to RR - Move line below a section break to match RR - Fix straight quote into smart quote
- Adjust grammar and punctuation to be closer to RR
- Adjust grammar, punctuation, formatting to be closer to RR
- Adjust grammar, punctuation, formatting to be closer to RR - Fix apostrophe direction on abbreviated year
- Adjust grammar, punctuation, formatting to be closer to RR - Restore author note
- Add italics on spell name - Use CSS class for underline instead of misusing the 'u' tag
- Revert 'all right' to 'alright' in dialogue - Restore capital letters when Harry is shouting at the top of his voice - Fix direction of apostrophe for omitted 'h'
- restore space in truncated sentence - restore plural 'formulae'
- Restore section break - Use original spelling/grammar/punctuation when both are valid
- Add italics to incantations - Fix italics around punctuation
- Restore capitalisation of shouted words - Put full stop outside italics when it's not part of the emphasis.
- Fix typo - Adjust punctuation, grammar, and line breaks to match RR when feasible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.