Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync with Royal Road chapters #31

Open
ThrawnCA opened this issue Dec 20, 2023 · 5 comments
Open

Sync with Royal Road chapters #31

ThrawnCA opened this issue Dec 20, 2023 · 5 comments

Comments

@ThrawnCA
Copy link
Contributor

Royal Road has been updated (hooray!) to chapter 29. We should trawl the new chapters to see if the Authorlord has changed anything worth incorporating into the eBook.

I've already adjusted a few minor bits of punctuation in chapter 2, will push soon.
ThrawnCA added a commit to ThrawnCA/hpnofp-ebook that referenced this issue Dec 20, 2023
@ThrawnCA
adjust punctuation in chapter 2 based on Royal Road version, Intermit…
db6fbac 
…tentlyRupert#31

- Replace some hyphens with em-dashes
- Replace a full stop with a comma
- Drop some section breaks
- Fix the orientation of an apostrophe
IntermittentlyRupert added a commit that referenced this issue Dec 20, 2023
@IntermittentlyRupert
Merge pull request #32 from ThrawnCA/royalroad-sync-2023-12
ca3785f 
adjust punctuation in chapter 2 based on Royal Road version, #31
@ThrawnCA
Copy link
Contributor Author

Ooh, it's all the way up to chapter 43 now.

@ThrawnCA
Copy link
Contributor Author

Heh, releasing 2.2.5 might have been a bit hasty. I still have 41 more chapters to go through!

@IntermittentlyRupert
Copy link
Owner

I've got the release action configured to run on merge. If someone's enthusiastic enough to download the new version immediately, they're welcome to it. 😄

@ThrawnCA
Copy link
Contributor Author

ThrawnCA commented Dec 20, 2023 •
edited
Loading

Should I be targeting an intermediate branch, then?

Personally, I would prefer to keep releases manual. But it's your repo.

@IntermittentlyRupert
Copy link
Owner

I'm not super fussed either way. If you'd rather it all go out at once, I'm happy to accept all the chapters in one PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ThrawnCA @IntermittentlyRupert