Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch rules to object export style (fixes eslint v8+) #299

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Switch rules to object export style (fixes eslint v8+) #299

merged 1 commit into from
Nov 8, 2021

Conversation

idolize
Copy link
Contributor

@idolize idolize commented Oct 22, 2021

Fixes #298. Verified all tests pass.

From eslint docs:

In ESLint v7.0.0, rules that were written as a function (rather than object) were able to provide fixes. In ESLint v8.0.0, only rules written as an object are allowed to provide fixes and must have a meta.fixable property set to either "code" or "whitespace".

@idolize
Copy link
Contributor Author

idolize commented Oct 22, 2021

FYI @Intellicode

@Intellicode
Copy link
Owner

Hi @idolize, thanks for your PR! Could you maybe rebase such that the build can be picked up? It was broken due to the deprecation of the configured build image.

Update peer dependency version
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@idolize
Copy link
Contributor Author

idolize commented Nov 1, 2021

@Intellicode I just did a rebase squash - hopefully that triggers the new build appropriately!

@Intellicode Intellicode merged commit ded1dd1 into Intellicode:master Nov 8, 2021
@manovotny
Copy link

@Intellicode any idea when you'll cut a new release for this so we can get rid of the npm / yarn warning on not having || ^8?

npm WARN [email protected] requires a peer of eslint@^3.17.0 || ^4 || ^5 || ^6 || ^7 but none is installed. You must install peer dependencies yourself.

@idolize idolize deleted the eslint-8-fix branch December 9, 2021 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eslint 8.0 error when using --fix: Fixable rules must set the meta.fixable property to "code" or "whitespace"
3 participants