Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target Netstandard 2.0 #22

Merged
merged 5 commits into from
Dec 10, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netcoreapp2.0</TargetFramework>
Expand All @@ -7,9 +7,12 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.7.0" />
<PackageReference Include="xunit" Version="2.3.1" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.3.1" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.9.0" />
<PackageReference Include="xunit" Version="2.4.1" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.1">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
</PackageReference>
<DotNetCliToolReference Include="dotnet-xunit" Version="2.3.1" />
</ItemGroup>

Expand Down
9 changes: 9 additions & 0 deletions IntelliTect.IntelliWait/CustomDictionary.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<?xml version='1.0' encoding='utf-8' ?>
<Dictionary>
<Words>
<Recognized>
<Word>Intelli</Word>
<Word>Tect</Word>
</Recognized>
</Words>
</Dictionary>
18 changes: 12 additions & 6 deletions IntelliTect.IntelliWait/IntelliTect.IntelliWait.csproj
Original file line number Diff line number Diff line change
@@ -1,21 +1,27 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<Authors>Mike Curn</Authors>
<Authors>IntelliTect-Nuget; Mike Curn</Authors>
<Company>IntelliTect</Company>
<Description>Set of methods to facilitate waiting a certain amount of time for a delegate to evaluate, while ignoring certain exceptions while attempting to evaluate, and throwing after a specified time limit (or throwing immediately if an unexpected exception is encountered)</Description>
<PackageLicenseUrl>https://github.com/IntelliTect/IntelliTect/blob/master/LICENSE</PackageLicenseUrl>
<Copyright>2018</Copyright>
<Copyright>Copyright © IntelliTect 2018</Copyright>
<PackageProjectUrl>https://github.com/IntelliTect/IntelliTect</PackageProjectUrl>
<RepositoryUrl>https://github.com/IntelliTect/IntelliTect</RepositoryUrl>
<RepositoryType>Git</RepositoryType>
<PackageTags>ui test, automated test, testing, api test, web test, integration test, await, async</PackageTags>
<PackageReleaseNotes>Initial release for long-term home, independant from Selenium dependency</PackageReleaseNotes>
<AssemblyName>IntelliTect.IntelliWait</AssemblyName>
<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
</PropertyGroup>

<ItemGroup>
<CodeAnalysisDictionary Include="CustomDictionary.xml" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.6.2">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
</PackageReference>
</ItemGroup>
</Project>
4 changes: 2 additions & 2 deletions IntelliTect.IntelliWait/Wait.cs
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ private static async Task<TResult> ExecuteWait<TResult>(Func<TResult> actionToWa
{
exceptions.Add(ex);
}
await Task.Delay(250);
await Task.Delay(250).ConfigureAwait(false);
} while (sw.Elapsed < timeToWait);
throw new AggregateException(exceptions);
}
Expand All @@ -203,7 +203,7 @@ private static async Task ExecuteWait(Action actionToWaitForComplete, TimeSpan t
{
exceptions.Add(ex);
}
await Task.Delay(250);
await Task.Delay(250).ConfigureAwait(false);
} while (sw.Elapsed < timeToWait);
throw new AggregateException(exceptions);
}
Expand Down
20 changes: 12 additions & 8 deletions IntelliTect.Utilities.Tests/IntelliTect.Utilities.Tests.csproj
Original file line number Diff line number Diff line change
@@ -1,18 +1,22 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net462</TargetFramework>
<TargetFramework>netcoreapp2.0</TargetFramework>

<IsPackable>false</IsPackable>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.3.0" />
<PackageReference Include="Moq" Version="4.7.99" />
<PackageReference Include="MSTest.TestAdapter" Version="1.1.18" />
<PackageReference Include="MSTest.TestFramework" Version="1.1.18" />
<PackageReference Include="xunit" Version="2.2.0" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.2.0" />
<PackageReference Include="Moq" Version="4.10.0" />


<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.9.0" />
<PackageReference Include="xunit" Version="2.4.1" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.1">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
</PackageReference>
<DotNetCliToolReference Include="dotnet-xunit" Version="2.3.1" />
</ItemGroup>

<ItemGroup>
Expand Down
31 changes: 18 additions & 13 deletions IntelliTect.Utilities/IntelliTect.Utilities.csproj
Original file line number Diff line number Diff line change
@@ -1,22 +1,27 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<RootNamespace>IntelliTect.Utilities</RootNamespace>
<TargetFramework>net462</TargetFramework>
<Description>A utility library for IntelliTect</Description>
<Company>IntelliTect</Company>
<TargetFramework>netstandard2.0</TargetFramework>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<Company>IntelliTect-Nuget</Company>
<Authors>IntelliTect</Authors>
<Copyright>Copyright © IntelliTect 2017</Copyright>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
<CodeAnalysisRuleSet>..\SolutionRuleset.ruleset</CodeAnalysisRuleSet>
<RunCodeAnalysis>true</RunCodeAnalysis>
<DebugType>full</DebugType>
<DebugSymbols>true</DebugSymbols>
<Description>A utility library for IntelliTect</Description>
<PackageLicenseUrl>https://github.com/IntelliTect/IntelliTect/blob/master/LICENSE</PackageLicenseUrl>
<Copyright>Copyright © IntelliTect 2018</Copyright>
<PackageProjectUrl>https://github.com/IntelliTect/IntelliTect</PackageProjectUrl>
<RepositoryUrl>https://github.com/IntelliTect/IntelliTect</RepositoryUrl>
<RepositoryType>Git</RepositoryType>
<PackageTags>IntelliTect Utilities</PackageTags>
<PackageReleaseNotes>Upgraded to netstandard 2.0</PackageReleaseNotes>
<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
</PropertyGroup>
<ItemGroup>
<None Include="IntelliTect.Utilities.nuspec" />
<CodeAnalysisDictionary Include="CustomDictionary.xml" />
</ItemGroup>
<ItemGroup>
<CodeAnalysisDictionary Include="CustomDictionary.xml" />
<PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.6.2">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
</PackageReference>
</ItemGroup>
</Project>
17 changes: 0 additions & 17 deletions IntelliTect.Utilities/IntelliTect.Utilities.nuspec

This file was deleted.

6 changes: 6 additions & 0 deletions IntelliTect.sln
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "IntelliTect.IntelliWait", "
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "IntelliTect.IntelliWait.Tests", "IntelliTect.IntelliWait.Tests\IntelliTect.IntelliWait.Tests.csproj", "{174B4C67-DEFA-4387-A947-52395E4C79A5}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{7FB66610-EB11-460E-8CC8-F49044F452D0}"
ProjectSection(SolutionItems) = preProject
appveyor.yml = appveyor.yml
README.md = README.md
EndProjectSection
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Libraries
* IntelliTect.IntelliWait
- Wait: Set of methods to facilitate waiting a certain amount of time for a delegate to evaluate, while
ignoring certain exceptions while attempting to evaluate, and throwing after a specified time limit
(or throwing immediately if an unexpected exception is encountered).
(or throwing immediately if an unexpected exception is encountered).

Contributing
============
Expand Down
14 changes: 0 additions & 14 deletions SolutionRuleset.ruleset

This file was deleted.

37 changes: 37 additions & 0 deletions appveyor.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
version: 1.0.{build}
pull_requests:
do_not_increment_build_number: true
branches:
only:
- release
- master
skip_branch_with_pr: true
image: Visual Studio 2017
assembly_info:
patch: true
file: '**\AssemblyInfo.*'
assembly_version: '{version}'
assembly_file_version: '{version}'
assembly_informational_version: '{version}'
dotnet_csproj:
patch: true
file: '**\*.csproj'
version: '{version}'
package_version: '{version}'
assembly_version: '{version}'
file_version: '{version}'
informational_version: '{version}'
before_build:
- cmd: dotnet restore
build:
publish_nuget: true
publish_nuget_symbols: true
include_nuget_references: true
verbosity: minimal
deploy:
- provider: NuGet
api_key:
secure: ViQUgBR04fO//b45zYHRvlnQI/PRjxmhC7ur0opzxuQCDO/ejXnN6ZiSri1hbgoU
skip_symbols: true
on:
branch: release