Resolve net core shared nullability #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keboo
reviewed
Aug 20, 2019
| public static string GetNetCoreVersion() | ||
| { | ||
| Assembly assembly = typeof(System.Runtime.GCSettings).GetTypeInfo().Assembly; | ||
| var assemblyCodeBase = assembly.CodeBase ?? throw new ArgumentNullException("assemblyCodeBase"); |
There was a problem hiding this comment.
I don't think this is the correct exception type since "assemblyCodeBase" is not an argument. I would suggest using an InvalidOperationException.
Keboo
reviewed
Aug 20, 2019
| var assemblyCodeBase = assembly.CodeBase ?? throw new ArgumentNullException("assemblyCodeBase"); | ||
| string[] assemblyPath = assemblyCodeBase.Split(new[] { '/', '\\' }, StringSplitOptions.RemoveEmptyEntries); | ||
| int netCoreAppIndex = Array.IndexOf(assemblyPath, "Microsoft.NETCore.App"); | ||
| if (netCoreAppIndex > 0 && netCoreAppIndex < assemblyPath.Length - 2) |
There was a problem hiding this comment.
I realize this is the same as it was. But this code fails on *nix systems if Microsoft.NETCore.App is installed at the root.
"/Microsoft.NETCore.App"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.