Fix v8 listing runner #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
COsborn2
commented
Jun 25, 2019
COsborn2
commented
- Allow for user to type 2.1-2.6 to run a range of listings or 02.01-02.06
- Additionally allow user to type 2.1 to run the 2.1-2.6 listing
- Change type of argument[] from object[] to string[] to allow user input to be properly passed
- Update Readme.md to reflect changed behavior
- Remove Build.sln and update EssentialCSharp.sln to remove references to submodules. Neither solution will now reference the submodules and will instead use the Nuget package.
-Update Ch10 Tests csproj -Remove Chapter7 project reference from Chapter11 proj -Update Chapter11 csproj versions -Shared program now allows for all listings to be run. NOTE: Still requires that you set the chapter as the startup project and run only those listings within that chapter. I.E: Chapter2 as startup cannot run chapter 5 listings
- Remove Build.sln. No slns will now reference the TestTools submodules - Remove ChapterTests.targets reference to submodules - Program runner will now specify current chapter in e.g. listing. This should indicate to the user that listings from other chapters cannot be run
COsborn2
force-pushed
the
fix-v8-listing-runner
branch
from
9504a43 to
a5663c4
Compare
Keboo
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.