Updated Chapters 2/3/4 with corrections #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminMichaelis
requested changes
Jun 10, 2021
There was a problem hiding this comment.
Some good changes here! Thank you! It looks like some of the tests need to be updated is the most pressing problem I see currently, as 3 tests are failing, but one looks like the content might of still be incorrect even after a change (4.02, I left comments on these). If you would be willing to update these tests that would be awesome, otherwise I don't mind making the changes needed and pushing them to your branch if you would like.
If you checkout on v8.0 only then it will only checkout v8.0, not the branch trying to be pulled in.
…Sv8.0 Update Build Checkout If you checkout on v8.0 only then it will only checkout v8.0 to test, not the branch trying to be pulled in.
…arious-additional-fixes
|
@kNoAPP I just wanted to follow up and see if you wanted to update this with the changes or if I should start work on it otherwise! |
|
You can start work on it! Sorry for the super late reply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errata: Added log of significant changes.
2.15: Added public identifiers to correct Reflection error.
2.17: Added a space in code to match book.
3.9/10/11/12/20/21/27/28: Replaced "Pascal" with "Visual Basic" to match book.
3.27: Removed whitespace for the additional example.
4.18: Code comments for incrementing example were incorrect. They've been updated to match the book.
Program: Added "Listing" to Regex because it confused Listing.cs files with Table.cs files causing Listings 4.4/7.3/etc. to fail.