-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coverlet collector for code coverage creation via dotnet test #157
Conversation
@twofingerrightclick would you prefer to do this in two steps or one to get the builds running, I can pull in this one with windows as it is looking good and then you can open a separate pr with the linux build fix or do you want to try to get both running here |
@BenjaminMichaelis the Linux build pipeline just has to be updated with the correct test command... I only updated the Windows pipeline... So i will update the Linux and hopefully it'll all be working. |
@twofingerrightclick I will wait then to merge, thank you! |
@BenjaminMichaelis Its good to go! |
@twofingerrightclick did you mean to add an update to the linux build as well? I don't see that yet, or are you shooting for another PR with that as I still see it failing here |
@BenjaminMichaelis the pipeline is only in Azure Devops.... Not a file in git.... It was updated and is working. The Linux pipeline is failing randomly due to an existing test unrelated to this pull request (this pr just made it so that code coverage and test results show up in the little Azure build widgets) that uses threads. Chapter20.Listing20_11.ProgramTests.AsyncVoidReturnTest. Like the test will sometimes pass, and sometimes fail depending on how Linux manages the threads it appears. |
@MarkMichaelis is there an update you would like to make to this test Chapter20.Listing20_11.ProgramTests.AsyncVoidReturnTest to see if it can be made more consistently passing? |
@BenjaminMichaelis Yeah, Ill take a look at it tomorrow probably. Learn some more c# threading... Ill read the section in the book and see whats up, but also it might be an os thing, and Ill have to set up a linux enviroment to debug it? |
When dotnet Test (Test Execution Command Line Tool) Version 16.8.1 changed to 16.8.3 code coverage stopped being published. Now need to use coverlet collector