Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverlet collector for code coverage creation via dotnet test #157

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

twofingerrightclick
Copy link
Contributor

When dotnet Test (Test Execution Command Line Tool) Version 16.8.1 changed to 16.8.3 code coverage stopped being published. Now need to use coverlet collector

@BenjaminMichaelis
Copy link
Member

@twofingerrightclick would you prefer to do this in two steps or one to get the builds running, I can pull in this one with windows as it is looking good and then you can open a separate pr with the linux build fix or do you want to try to get both running here

@twofingerrightclick
Copy link
Contributor Author

@BenjaminMichaelis the Linux build pipeline just has to be updated with the correct test command... I only updated the Windows pipeline... So i will update the Linux and hopefully it'll all be working.

@BenjaminMichaelis
Copy link
Member

@twofingerrightclick I will wait then to merge, thank you!

@twofingerrightclick
Copy link
Contributor Author

twofingerrightclick commented Apr 1, 2021

@BenjaminMichaelis Its good to go!

@twofingerrightclick twofingerrightclick merged commit e114fe7 into v8.0 Apr 1, 2021
@twofingerrightclick twofingerrightclick deleted the AddCoverlet branch April 1, 2021 00:18
@BenjaminMichaelis
Copy link
Member

BenjaminMichaelis commented Apr 1, 2021

@twofingerrightclick did you mean to add an update to the linux build as well? I don't see that yet, or are you shooting for another PR with that as I still see it failing here

@twofingerrightclick
Copy link
Contributor Author

twofingerrightclick commented Apr 1, 2021

@BenjaminMichaelis the pipeline is only in Azure Devops.... Not a file in git.... It was updated and is working.

The Linux pipeline is failing randomly due to an existing test unrelated to this pull request (this pr just made it so that code coverage and test results show up in the little Azure build widgets) that uses threads. Chapter20.Listing20_11.ProgramTests.AsyncVoidReturnTest.

Like the test will sometimes pass, and sometimes fail depending on how Linux manages the threads it appears.

@BenjaminMichaelis
Copy link
Member

@MarkMichaelis is there an update you would like to make to this test Chapter20.Listing20_11.ProgramTests.AsyncVoidReturnTest to see if it can be made more consistently passing?

@twofingerrightclick
Copy link
Contributor Author

twofingerrightclick commented Apr 1, 2021

@BenjaminMichaelis Yeah, Ill take a look at it tomorrow probably. Learn some more c# threading... Ill read the section in the book and see whats up, but also it might be an os thing, and Ill have to set up a linux enviroment to debug it?
The next pr might just be marking that test to be skipped on Linux.
And I ran the linux pipeline again, and the test passed. haha. Now it looks nice and green lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants