Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove VT100 chars before Assert #123

Merged
merged 3 commits into from
Mar 31, 2020
Merged

Remove VT100 chars before Assert #123

merged 3 commits into from
Mar 31, 2020

Conversation

COsborn2
Copy link
Contributor

No description provided.

@COsborn2 COsborn2 requested review from Keboo and MarkMichaelis March 31, 2020 19:12
@Keboo
Copy link
Member

Keboo commented Mar 31, 2020

This works but is there a reason we are parsing the string twice to do the removals? Why not do the char 27 removal with the regex too so you only process the string once?

@COsborn2 COsborn2 merged commit 1e49f57 into v8.0 Mar 31, 2020
@COsborn2 COsborn2 deleted the bug/VT100-assert-remove branch April 20, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keboo Keboo Keboo approved these changes

@MarkMichaelis MarkMichaelis Awaiting requested review from MarkMichaelis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@COsborn2 @Keboo