Simplify Plot#getConnectedPlots and share cache between connected plots #4212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dordsor21
reviewed
Oct 20, 2023
NotMyFault
approved these changes
Oct 21, 2023
dordsor21
approved these changes
Oct 22, 2023
SirYwell
added a commit
that referenced
this pull request
Nov 16, 2023
…ts (#4212) * Simplify Plot#getConnectedPlots and share cache between connected plots * add missing isMerged check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #4203
Description
Previously, each plot in a set of merged plots had its own connected plots cache. We can reduce this overhead by sharing the set. This reduces memory overhead if many plots are merged into one.
I also cleaned up the repetitive code.
Submitter Checklist