Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: No response to errors in plot user group modifications #4197

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Fix: No response to errors in plot user group modifications #4197

merged 4 commits into from
Oct 5, 2023

Conversation

PierreSchwang
Copy link
Member

Overview

Fixes #4104

Description

  • Deprecates the old static methods to get a Caption from a users UUID
  • Added new method in PlayerManager to retrieve a Caption from a users UUID non-blocking
  • Removed thread-blocking and fast-timeout messages / captions
  • Added utility methods to send messages to players with asynchronously resolved TagResolvers

Submitter Checklist
Preview Give feedback

@PierreSchwang PierreSchwang requested a review from a team as a code owner October 2, 2023 21:45
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Oct 2, 2023
@PierreSchwang PierreSchwang added hacktoberfest-accepted Bugfix This PR fixes a bug and removed Bugfix This PR fixes a bug labels Oct 2, 2023
@PierreSchwang PierreSchwang requested a review from SirYwell October 3, 2023 10:19
NotMyFault
NotMyFault reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some optional feedback

Core/src/main/java/com/plotsquared/core/util/PlayerManager.java Outdated Show resolved Hide resolved
Core/src/main/java/com/plotsquared/core/util/PlayerManager.java Outdated Show resolved Hide resolved
@dordsor21 dordsor21 merged commit 0d2b36b into main Oct 5, 2023
@dordsor21 dordsor21 deleted the fix/playerComponents branch October 5, 2023 13:54
SirYwell pushed a commit that referenced this pull request Nov 16, 2023
@PierreSchwang @SirYwell
Fix: No response to errors in plot user group modifications (#4197)
bf52e2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotMyFault NotMyFault NotMyFault approved these changes

@SirYwell SirYwell SirYwell approved these changes

@dordsor21 dordsor21 dordsor21 approved these changes

Assignees
No one assigned
Labels
Bugfix This PR fixes a bug hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TagResolver / sendMessage problem
4 participants
@PierreSchwang @dordsor21 @SirYwell @NotMyFault