-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build a Mojang mapped jar in addition to the reobf one, publish both to Modrinth with correct metadata #2981
Open
jpenilla
wants to merge
7
commits into
IntellectualSites:main
Choose a base branch
from
jpenilla:publish-mojang-jar-for-paper
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Build a Mojang mapped jar in addition to the reobf one, publish both to Modrinth with correct metadata #2981
jpenilla
wants to merge
7
commits into
IntellectualSites:main
from
jpenilla:publish-mojang-jar-for-paper
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpenilla
force-pushed
the
publish-mojang-jar-for-paper
branch
2 times, most recently
from
November 9, 2024 01:09
00deb25
to
9a34d9f
Compare
Please take a moment and address the merge conflicts of your pull request. Thanks! |
…to Modrinth with correct metadata
…ar for their Minecraft version and platform combination
jpenilla
force-pushed
the
publish-mojang-jar-for-paper
branch
from
November 10, 2024 18:24
9a34d9f
to
832d61e
Compare
SirYwell
approved these changes
Nov 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
dordsor21
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes the need for remapping on Paper, reducing disk usage and first-start times.
Description
The project now builds two ShadowJars, one for Paper 1.20.5+ only (Mojmapped), and one that will work on Spigot or Paper for all versions (Spigot mapped).
We publish the Spigot jar to Modrinth twice to make sure their version selector picks the right jar for the platform regardless of the Minecraft version.
I've also added a runtime check on startup to notify the user when they have the wrong jar for their platform, tested with:
I'm also wondering if it's intentional that 1.20.4 is not in the supported list for Modrinth publishing but 1.20.3 and 1.19.4 are. Let me know and I can adjust this if needed.
I've updated the GitHub Actions, not sure if Jenkins will need changes or not.
Submitter Checklist
@since TODO
.