-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.21.3 #2974
1.21.3 #2974
Conversation
No issues so far, everything I've tested works as expected (property tab complete, masking, regen, modifying selections). Not sure if we want to add the new (1.21.4) block types and stuff as well (just like WE does in their 1.21.3 draft PR) or release 1.21.3 as is |
...ava/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_21_3/nbt/PaperweightLazyCompoundTag.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably worth going for 1.20.3 first and then adding the .4 stuff as necessary
...c/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_21_3/PaperweightFaweAdapter.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_21_3/PaperweightFaweAdapter.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_21_3/regen/PaperweightRegen.java
Outdated
Show resolved
Hide resolved
e9447f0
to
02eb4f6
Compare
I noticed that the versions are somewhat inconsistent. We currently support 1.20.2, 1.20.4, 1.20.6, 1.21.1, and 1.21.3, right? Could you also update the issue template? |
The versions are pulled from the actual versions supported by our adapters: |
Yes, but e.g. https://github.com/IntellectualSites/FastAsyncWorldEdit/pull/2974/files#diff-c0dfa6bc7a8685217f70a860145fbdf416d449eaff052fa28352c5cec1a98c06R86 doesn't mention 1.20.2 (but 1.20.5, which is covered by 1.20.6 basically), and the issue template is not up to date. |
I guess we could restrict supported versions to something like |
Yes, 1.20.2 should be added still, but otherwise just the latest version supported by the specific adapter version I guess. |
Overview
1.21.3 support
Submitter Checklist