Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improved entity operations #2356

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: improved entity operations #2356

wants to merge 8 commits into from
+1,275 −238

Conversation

dordsor21
Copy link
Member

@dordsor21 dordsor21 requested a review from a team as a code owner July 15, 2023 12:00
@github-actions github-actions bot added the Feature This PR adds a new feature label Jul 15, 2023
@github-actions
Copy link

Please take a moment and address the merge conflicts of your pull request. Thanks!

@github-actions GitHub Actions
Copy link

Please take a moment and address the merge conflicts of your pull request. Thanks!

@NotMyFault
Copy link
Member

Please rebase for 1.20.3/4

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024

Please take a moment and address the merge conflicts of your pull request. Thanks!

@dordsor21 dordsor21 requested a review from SirYwell March 16, 2024 15:44
@github-actions GitHub Actions
Copy link

Please take a moment and address the merge conflicts of your pull request. Thanks!

@SirYwell
Copy link
Member

I'm only seeing any FAWE block changes only after rejoining, not sure why though.

@SirYwell SirYwell mentioned this pull request Mar 24, 2024
Merged
@dordsor21
Copy link
Member Author

I'm only seeing any FAWE block changes only after rejoining, not sure why though.

I can't replicate this, but I have, however, found that copy now copies entities in the full chunks aha

SirYwell
SirYwell approved these changes Apr 6, 2024
View reviewed changes
Copy link
Member

@SirYwell SirYwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't reproduce the invisible change issue anymore. The changes seem to work from my testing and the code looks good.

@dordsor21 dordsor21 requested a review from a team April 12, 2024 10:06
@github-actions GitHub Actions
Copy link

Please take a moment and address the merge conflicts of your pull request. Thanks!

@github-actions GitHub Actions
Copy link

Please take a moment and address the merge conflicts of your pull request. Thanks!

@github-actions GitHub Actions
Copy link

Please take a moment and address the merge conflicts of your pull request. Thanks!

@dordsor21 dordsor21 force-pushed the feat/improved-entity-operations branch from e444638 to 88b7b80 Compare September 11, 2024 21:30
@github-actions GitHub Actions
Copy link

Please take a moment and address the merge conflicts of your pull request. Thanks!

@dordsor21 dordsor21 force-pushed the feat/improved-entity-operations branch from 88b7b80 to 6d6f704 Compare September 14, 2024 09:29
@github-actions GitHub Actions
Copy link

Please take a moment and address the merge conflicts of your pull request. Thanks!

@dordsor21 dordsor21 force-pushed the feat/improved-entity-operations branch from 6d6f704 to fa390a0 Compare September 17, 2024 19:49
@github-actions GitHub Actions
Copy link

Please take a moment and address the merge conflicts of your pull request. Thanks!

@dordsor21 dordsor21 force-pushed the feat/improved-entity-operations branch from fa390a0 to 7811de9 Compare September 20, 2024 22:15
@github-actions GitHub Actions
Copy link

Please take a moment and address the merge conflicts of your pull request. Thanks!

@dordsor21 dordsor21 force-pushed the feat/improved-entity-operations branch from 7811de9 to 8f7c4bc Compare September 25, 2024 17:30
@dordsor21 dordsor21 force-pushed the feat/improved-entity-operations branch from 8f7c4bc to b944e2e Compare October 26, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirYwell SirYwell SirYwell approved these changes

Assignees
No one assigned
Labels
Feature This PR adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copying + pasting entities works only over a distance of viewdistance + 2 chunks
3 participants
@dordsor21 @NotMyFault @SirYwell