Added upstream OffsetsMask classes #2210
Open
+566
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The checks seem to have failed but the code does compile and works. Not sure what is the cause of the failure to resolve dependencies and the CodeQL issue. I don’t even touch dependencies in this PR. |
dordsor21
reviewed
May 12, 2023
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
That's a question for @me4502 to answer. Hopefully, she can clarify for us.
There was a problem hiding this comment.
Most likely, generally deprecations are for removal in the next major version
there’s not much point having two classes that do the same thing here
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes one of the API incompatibilities we have with upstream by adding these new masks to FAWE.
Description
Adds two new masks to FAWE from upstream and ports a few FAWE changes into them.
Submitter Checklist
@since TODO.