Skip to content

Commit

Permalink
Add tests for redisFree() and freeReplyObject()
Browse files Browse the repository at this point in the history
Test that redisFree() and freeReplyObject() do not crash when NULL is
passed in.
  • Loading branch information
dmelani committed May 29, 2014
1 parent 05b85eb commit 21a1207
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions test.c
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,19 @@ static void test_reply_reader(void) {
redisReaderFree(reader);
}

static void test_free_null(void) {
void *redisContext = NULL;
void *reply = NULL;

test("Don't fail when redisFree is passed a NULL value: ");
redisFree(redisContext);
test_cond(redisContext == NULL);

test("Don't fail when freeReplyObject is passed a NULL value: ");
freeReplyObject(reply);
test_cond(reply == NULL);
}

static void test_blocking_connection_errors(void) {
redisContext *c;

Expand Down Expand Up @@ -702,6 +715,7 @@ int main(int argc, char **argv) {
test_format_commands();
test_reply_reader();
test_blocking_connection_errors();
test_free_null();

printf("\nTesting against TCP connection (%s:%d):\n", cfg.tcp.host, cfg.tcp.port);
cfg.type = CONN_TCP;
Expand All @@ -723,6 +737,7 @@ int main(int argc, char **argv) {
test_blocking_connection(cfg);
}


if (fails) {
printf("*** %d TESTS FAILED ***\n", fails);
return 1;
Expand Down

0 comments on commit 21a1207

Please sign in to comment.