d4xx: hwmc return success on ioctl #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LRS expects success on hwmc ioctl call. [Error] /tmp/sandbox/src/librealsense-exception.h:52 - xioctl(VIDIOC_G_EXT_CTRLS) failed Last Error: Bad message Signed-off-by: Dmitry Perchanov <[email protected]>
Nir-Az
reviewed
Mar 20, 2024
| @@ -2514,8 +2514,10 @@ static int ds5_g_volatile_ctrl(struct v4l2_ctrl *ctrl) | |||
| u16 dataLen = 0; | |||
| u16 bufLen = ctrl->dims[0]; | |||
| ret = ds5_get_hwmc(state, data, bufLen, &dataLen); | |||
| if (ret) | |||
| if (ret) { | |||
There was a problem hiding this comment.
Let's speak about it,
We should get real return value from FW
Nir-Az
approved these changes
Mar 21, 2024
Nir-Az
added a commit
to Nir-Az/realsense_mipi_platform_driver
that referenced
this pull request
Mar 24, 2024
(cherry picked from commit cf7fe64)
Nir-Az
added a commit
that referenced
this pull request
Mar 24, 2024
dmipx
pushed a commit
to dmipx/realsense_mipi_platform_driver
that referenced
this pull request
Apr 7, 2024
(cherry picked from commit cf7fe64)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LRS expects success on hwmc ioctl call.
[Error] /tmp/sandbox/src/librealsense-exception.h:52 - xioctl(VIDIOC_G_EXT_CTRLS) failed Last Error: Bad message