-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bug on DQT on custom mode #8289
Conversation
auto depth_profile = dev.get_stream(RS2_STREAM_DEPTH); | ||
auto w = depth_profile.as<video_stream_profile>().width(); | ||
auto h = depth_profile.as<video_stream_profile>().height(); | ||
depth_sensor.set_option(RS2_OPTION_SENSOR_MODE, resolution_from_width_height(w, h)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The option is L500-only. Will throws with D400
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Ok, some minor fix is required
{ RS2_L500_VISUAL_PRESET_LOW_AMBIENT, { RS2_DIGITAL_GAIN_LOW, defualt_laser } }, | ||
{ RS2_L500_VISUAL_PRESET_SHORT_RANGE, { RS2_DIGITAL_GAIN_LOW, max_laser } } }; | ||
{ RS2_L500_VISUAL_PRESET_LOW_AMBIENT, { RS2_DIGITAL_GAIN_LOW, max_laser } }, | ||
{ RS2_L500_VISUAL_PRESET_SHORT_RANGE, { RS2_DIGITAL_GAIN_LOW, defualt_laser } } }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo - default
@@ -52,8 +52,8 @@ const std::map< rs2_l500_visual_preset, std::pair< rs2_digital_gain, presets_use | |||
preset_to_gain_and_laser_map | |||
= { { RS2_L500_VISUAL_PRESET_NO_AMBIENT, { RS2_DIGITAL_GAIN_HIGH, defualt_laser } }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default
In custom mode we need to update the sensor with sensor mode before start.