Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3803 Removed the requirement of additional hid devices #3804

Merged
merged 1 commit into from
Apr 29, 2019
Merged

#3803 Removed the requirement of additional hid devices #3804

merged 1 commit into from
Apr 29, 2019

Conversation

state-of-the-art
Copy link

The IMU is a great part of the camera, but not so required to actually connect the camera and get the depth stream from it.
Removing this HID requirement will help to use this cameras on the android devices right now.

@radfordi
Copy link
Contributor

This is required to use the D435i on a Mac as well where HID devices are not yet supported.

@dorodnic
Copy link
Contributor

Can we put it under some kind of #ifdef ANDROID || MAC?
On Windows and Linux this breaks dynamic camera discovery, unfortunately.

@state-of-the-art
Copy link
Author

state-of-the-art commented Apr 28, 2019

So we removing just check here - it will not affect the platforms where the support of HID is in place.

The change is about do not check HID devices during the camera connection - HID modules will check this later and add the proper functionality if they are existing, otherwise will print warning that HID devices are not existing (as described in #3803 ).

@dorodnic
Copy link
Contributor

Thanks @state-of-the-art
Yes, I understand what you are trying to do, unfortunately it does affect platforms with HID support. You do not know ahead of time the order of enumeration of different interfaces (Depth, RGB, HID). When HID is discovered last, it will be too late, since given RGB+Depth alone D400 factory will decide it has enough to declare connection of D435i, and upper levels will not know to dynamically "add" HID when it completes enumeration.

@state-of-the-art
Copy link
Author

Hi @dorodnic,
If I got it correctly - the factory will retry to create the device later when the HID devices will be available? That makes sense, I will prepare the requested changes in a minute.
Thank you

The IMU is a great part of the camera, but not so required to actually connect the camera and get the depth stream from it.
Removing this HID requirement will help to use this cameras on the android devices right now.
@dorodnic
Copy link
Contributor

@state-of-the-art Thanks :)
Yes, every time there is any change in OS hardware, the context factory will try to build new RealSense devices out of OS devices available.

@dorodnic dorodnic changed the base branch from master to development April 29, 2019 10:37
@dorodnic
Copy link
Contributor

I re-targeted the PR to comply with CONTRIBUTING.md, but it will be part of the next release (this week)

@dorodnic dorodnic merged commit 312a1e6 into IntelRealSense:development Apr 29, 2019
@state-of-the-art state-of-the-art deleted the patch-1 branch April 30, 2019 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants