-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase examples waiting time for first frame to 15 seconds #3795
Increase examples waiting time for first frame to 15 seconds #3795
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Some minor comments inside
examples/C/depth/rs-depth.c
Outdated
const rs2_stream_profile* stream_profile = rs2_get_stream_profile(stream_profile_list, 0, &e); | ||
if (e) | ||
{ | ||
printf("Failed to create stream profile list!\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C&P - update the message
examples/C/color/rs-color.c
Outdated
@@ -79,7 +79,7 @@ int main() | |||
// This call waits until a new composite_frame is available | |||
// composite_frame holds a set of frames. It is used to prevent frame drops | |||
// The retunred object should be released with rs2_release_frame(...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type retunred returned
common/model-views.h
Outdated
@@ -665,7 +665,7 @@ namespace rs2 | |||
bool metadata_displayed = false; | |||
bool capturing_roi = false; // active modification of roi | |||
std::shared_ptr<subdevice_model> dev; | |||
float _frame_timeout = 5000.0f; | |||
float _frame_timeout = RS_DEFAULT_TIMEOUT; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename to RS2_DEFAULT_TIMEOUT for consistency
examples/C/distance/rs-distance.c
Outdated
@@ -80,7 +80,7 @@ int main() | |||
// This call waits until a new composite_frame is available | |||
// composite_frame holds a set of frames. It is used to prevent frame drops | |||
// The retunred object should be released with rs2_release_frame(...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same typo as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
No description provided.