Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase examples waiting time for first frame to 15 seconds #3795

Merged
merged 2 commits into from
Apr 21, 2019

Conversation

matkatz
Copy link
Contributor

@matkatz matkatz commented Apr 18, 2019

No description provided.

@matkatz matkatz requested a review from ev-mp April 18, 2019 13:14
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Some minor comments inside

const rs2_stream_profile* stream_profile = rs2_get_stream_profile(stream_profile_list, 0, &e);
if (e)
{
printf("Failed to create stream profile list!\n");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C&P - update the message

@@ -79,7 +79,7 @@ int main()
// This call waits until a new composite_frame is available
// composite_frame holds a set of frames. It is used to prevent frame drops
// The retunred object should be released with rs2_release_frame(...)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type retunred returned

@@ -665,7 +665,7 @@ namespace rs2
bool metadata_displayed = false;
bool capturing_roi = false; // active modification of roi
std::shared_ptr<subdevice_model> dev;
float _frame_timeout = 5000.0f;
float _frame_timeout = RS_DEFAULT_TIMEOUT;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to RS2_DEFAULT_TIMEOUT for consistency

@@ -80,7 +80,7 @@ int main()
// This call waits until a new composite_frame is available
// composite_frame holds a set of frames. It is used to prevent frame drops
// The retunred object should be released with rs2_release_frame(...)
Copy link
Collaborator

@ev-mp ev-mp Apr 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same typo as above

Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@ev-mp ev-mp merged commit 216b283 into IntelRealSense:development Apr 21, 2019
@matkatz matkatz deleted the default_wff_timeout branch November 5, 2019 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants