libuvc: fix undefined behavior caused by capture-by-reference of local variable #3783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l variable It appears this was introduced in 9d17956.
radfordi
approved these changes
Apr 22, 2019
dorodnic
approved these changes
Apr 28, 2019
|
Thanks @WasabiFan @radfordi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"&" captures all used variables by reference; as mentioned in this Stack Overflow question, that causes undefined behavior if the lambda is invoked after the function's stack frame is deallocated.
This means that the child thread was dereferencing a pointer from the other thread's stack frame -- sometimes it would happen to work because that data was still there, and other times it wouldn't and the process would segfault.
It appears this was introduced in 9d17956.