Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unity] Support linear color space #3687

Merged
merged 2 commits into from
Apr 29, 2019
Merged

[Unity] Support linear color space #3687

merged 2 commits into from
Apr 29, 2019

Conversation

tarukosu
Copy link
Contributor

@tarukosu tarukosu commented Apr 5, 2019 •
edited
Loading

When color mode setting is Linear, a color image texture looks brighter than it actually is.
This PR fixes the problem.

image

@dorodnic
Copy link
Contributor

dorodnic commented Apr 7, 2019

Hi @tarukosu
Thank you for the patch!

@dorodnic dorodnic requested a review from ogoshen April 7, 2019 05:09
@dorodnic dorodnic added the unity label Apr 7, 2019
ogoshen
ogoshen suggested changes Apr 7, 2019
View reviewed changes
Copy link
Contributor

@ogoshen ogoshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight problem here with non-color textures (i.e depth, uv etc.)
I suggest either enabling this for Stream.Color and Stream.Infrared only, or adding this as configurable option, like in Unity's RenderTexture:

image

@tarukosu
Copy link
Contributor Author

@ogoshen Thank you for your comment!
I enabled this change only for Stream.Color and Stream.Infrared.

@dorodnic dorodnic merged commit 8a151c3 into IntelRealSense:development Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogoshen ogoshen ogoshen requested changes

@dorodnic dorodnic dorodnic approved these changes

Assignees
No one assigned
Labels
unity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tarukosu @dorodnic @ogoshen