Promote T265 FW Tag; Minor SDK fixes #3669
Conversation
ev-mp
commented
Apr 3, 2019
•
ev-mp
commented
- Promote T265 Firmware tag to 0.0.18.5448
- Update log level for T265-specific cases
- SDK's Cmake private files list - remove duplicates, add missing headers
- GCC [wpedantic] warning - Remove unnecessary semicolon
| "${CMAKE_CURRENT_LIST_DIR}/types.h" | ||
| "${CMAKE_CURRENT_LIST_DIR}/backend.h" | ||
| "${CMAKE_CURRENT_LIST_DIR}/device.h" | ||
| "${CMAKE_CURRENT_LIST_DIR}/api.h" |
There was a problem hiding this comment.
@ev-mp because you sorted this list and changed its contents at the same time, it's hard to see what changed here. I see at least ivcam/ivcam-private.h is now gone, which is unrelated to T265 as far as I know.
There was a problem hiding this comment.
These changes rectify inconsistencies discovered during the validation of the new TM2 FW. And they are separate from the FW update commit
| @@ -58,4 +58,4 @@ namespace librealsense | |||
|
|
|||
| _color_device_idx = add_sensor(create_color_device(ctx, color_devs_info)); | |||
| } | |||
| }; | |||
| } | |||
There was a problem hiding this comment.
This seems unrelated to T265, so probably shouldn't be in this PR
| @@ -951,7 +951,7 @@ namespace librealsense | |||
| } | |||
| else | |||
| { | |||
| LOG_WARNING("Dropped frame. alloc_frame(...) returned nullptr"); | |||
| LOG_INFO("Dropped frame. alloc_frame(...) returned nullptr"); | |||
There was a problem hiding this comment.
In what scenario would alloc_frame return a nullptr that doesn't justify a warning?
There was a problem hiding this comment.
The warning occurs whenever frames acquired by users are not released in a timely manner.
We observe it some OpenGl-enabled demos where the default frames queue allocated in the SDK (size=16) is probably not enough to compensate for 3D scene render.
There was a problem hiding this comment.
The main problem is that this is a negative feedback loop - frame drops cause console output, slowing the app and causing more frame drops.
A better solution that we discussed for a while (I think @aangerma tried implementing at some point) is for processing blocks to implement notification extension (like the sensor does) and manage some basic internal statistics. This way, we can avoid spamming the output with such warnings...
There was a problem hiding this comment.
@ev-mp Should we make the frame queue deeper for imu data which is small but high rate?
ev-mp
changed the title
Change-Id: I44cf76237e005f175523274717570e22a39eaf43 (cherry picked from commit d72b3ab0b9e34bb997ba5c775d77c1e1f4e25487)
…ing header Reduce log report level in TM2-specific scenarios. Handle remove trailing whitespaces and GCC -wPedantic warning Fix Librelasense cmake private files list Change-Id: If3c1c873aefec7c5a876892dac399f75199e6499 (cherry picked from commit 7df5e5bcc7ef6650df03a705398375d26ebc5a87) Signed-off-by: Evgeni Raikhel <[email protected]>
