-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake improvements for Windows build #3611
CMake improvements for Windows build #3611
Conversation
Thanks @claudiofantacci |
Thanks for your feedback @dorodnic, really appreciated 🎉
This. Is. Awesome! |
@claudiofantacci , the mentioned merge resulted in a merge conflicts with this PR. |
@ev-mp sure I will! I’m out of office now, I’ll do everything tomorrow 🙂 |
This needs rebasing, @claudiofantacci, now that #3647 has been merged. |
11acde7
to
292fb8b
Compare
I just rebased on top of |
Thanks @claudiofantacci. Yes, the |
@radfordi exactly! Only those two points 🙂 |
@claudiofantacci thank you for contributing! |
This PR is a followup of issue #3597 that tries to address the problem of #3483 and to add
CMAKE_DEBUG_POSTFIX
when compiling withMS Visual Studio
and emulators (those that are recognized by CMake asMSVC
generators).The main difference lies in
⚠️ Note that strange indentation of the
third-party/libtm/resources/CMakeLists.txt
where multiplefile(APPEND ...)
commands are replaced with a singlefile(WRITE ...)
command. This is to resolve a problem where sometimes the files where malformed.file(WRITE ...)
commands is necessary to have a proper indentation in the generated files. If you don't like it (I personally don't 😄) I reformat the string into a single line by adding\n
s, but I think the result is even uglier than the former and much less readable 🙃.I also added two new entries in the
.gitignore
file:build
, for example I may have a folderbuild
for Release and abuildd
folder for Debug.Note that in order to close #3597 we also need #3507 to be merged.
Fixes #3483.