Fix duplicated serial numbers on MacOS #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adresses no SR300 available, MacOS and libuvc in general. tracked on DSO-9231
dorodnic
reviewed
Jun 6, 2018
src/libuvc/libuvc.cpp
Outdated
| @@ -139,6 +139,10 @@ namespace librealsense | |||
|
|
|||
| libusb_free_config_descriptor(config); | |||
| } | |||
| else if (status < 0) | |||
There was a problem hiding this comment.
I would avoid throwing from foreach_device block, since it will prevent you from discovering all devices.
There was a problem hiding this comment.
I will remove it, as it throws on MacOS, and use the previous logic (no action)
dorodnic
approved these changes
Jun 10, 2018
This was referenced Jun 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix SR300 not found when using libuvc backend
Tracked on: DSO-9231, #1506. probably related to #1779, #1089