Unit test for end recording and start streaming again bug fix #12541
Conversation
| dev = test.find_first_device_or_exit() | ||
| depth_sensor = dev.first_depth_sensor() | ||
| find_default_profile() | ||
| record() |
There was a problem hiding this comment.
Don't you need to pass the file_name? maybe it's better to pass it?
| temp_dir = tempfile.mkdtemp() | ||
| file_name = os.path.join(temp_dir, "recording.bag") | ||
|
|
||
| sync = rs.syncer() |
There was a problem hiding this comment.
Why do we need the syncer?
There was a problem hiding this comment.
we use it to wait for frames and check that the streaming after recording worked well
There was a problem hiding this comment.
Looks like there is nothing to sync since we have only 1 profile.
Maybe we can use a frame queue instead?
Please check the it in the API..
| sync = rs.syncer() | ||
| dev = test.find_first_device_or_exit() | ||
| depth_sensor = dev.first_depth_sensor() | ||
| find_default_profile() |
There was a problem hiding this comment.
I would expect it to return a profile and to pass it to the streaming function? or even being in side the streaming function ?
| record() | ||
|
|
||
| # after we finish recording we close the sensor and then open it again and try streaming | ||
| try_streaming() |
|
Please check this: |
|
|
||
| ctx = rs.context() | ||
| playback = ctx.load_device(file_name) | ||
| depth_sensor = playback.first_depth_sensor() | ||
|
|
||
| depth_profile = restart_profile(default_profile) | ||
| depth_sensor.open(depth_profile) | ||
| depth_sensor.start(sync) | ||
| depth_sensor.start(frame_queue) |
There was a problem hiding this comment.
Can we reuse try_streaming again maybe here?
and I am not sure but you might want to clear the frame queue between both usage
| temp_dir = tempfile.mkdtemp() | ||
| file_name = os.path.join(temp_dir, "recording.bag") | ||
|
|
||
| sync = rs.syncer() | ||
| frame_queue = rs.frame_queue(1000) |
There was a problem hiding this comment.
Why 1000? :)
Do it has a default?
There was a problem hiding this comment.
The default is 1, I can change the capacity to be smaller.
There was a problem hiding this comment.
Let's decrease it to allocate less memory..
Tracked by RSDEV-1226