Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deadlock test & unit-test-config now listens to donotrun #12282

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

maloel
Copy link
Collaborator

@maloel maloel commented Oct 11, 2023

Following #12275, this adds the test that was used to reproduce:

  • even with one device.
  • only on Linux

Made it only run on the nightly.
Tried with Python, but failed to reproduce.

On the way, made unit-test-config actually pay attention to the donotrun directives in our unit-tests (so, for example, nightly tests aren't even build in non-nightly builds).

Tracked on [RSDSO-19304]

@maloel maloel requested a review from remibettan October 11, 2023 11:53
Copy link
Contributor

@remibettan remibettan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the aim of the test to check that deadlock occurs?
Regarding the other line in unit-test-config, please explain

@maloel
Copy link
Collaborator Author

maloel commented Oct 11, 2023

Is the aim of the test to check that deadlock occurs?

The aim is to check if the deadlock occurs: if it does, then a timeout will be reached after 12 seconds and the test will fail

Regarding the other line in unit-test-config, please explain

See the description...
unit-test-config.py now pays attention to the donotrun directive so, for example, nightly tests aren't even built in non-nightly builds). This saves on compilation times if the tests aren't going to run.

@remibettan remibettan self-requested a review October 11, 2023 14:00
Copy link
Contributor

@remibettan remibettan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maloel maloel merged commit 9c35d0d into IntelRealSense:development Oct 11, 2023
@maloel maloel deleted the deadlock branch October 11, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants