Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev -> dds; remove sw_device_extra_data #11558

Merged
merged 46 commits into from
Mar 12, 2023
Merged

dev -> dds; remove sw_device_extra_data #11558

merged 46 commits into from
Mar 12, 2023

Conversation

maloel
Copy link
Collaborator

@maloel maloel commented Mar 12, 2023 •
edited
Loading

Now that the metadata can encompass all fields (#11551), no need for sw_device_extra_data.

Tamir91 and others added 30 commits February 23, 2023 16:23
@Tamir91
-pedantic flag disabled for glfw on Unix
a51efc8
@Nir-Az
move stuff to and from common
d843ced
@Nir-Az
PR IntelRealSense#11477 from Tamir91: Reduce compilation warnings -pe…
4dcc8f7 
…dantic flag disabled for glfw on Unix
@Nir-Az
undo type change
d55a6df
@Nir-Az
PR IntelRealSense#11479 from Nir-Az: Move stuff to and from common DS
2c85f7f
@Nir-Az
add floders to pr_check
cb5ead9
@Nir-Az
fix issues
fdf290c
@Nir-Az
convert EOL to Unix style
dcce768
@Nir-Az
add missing copyrights
d9a94e1
@maloel
fix crash from leftover T265
e648619
@Nir-Az
PR IntelRealSense#11484 from Nir-Az: Pr check update
e1a44f8
@Nir-Az
PR IntelRealSense#11488 from maloel: fix crash from leftover T265
7826fff
@Tamir91
python versions support updated
6d2eb97
@Tamir91
git moved to early step
d68973c
@Nir-Az
PR IntelRealSense#11495 from Tamir91: The python support versions wer…
42faf0e 
…e updated
@Tamir91
the stage name was changed
1f38f8e
@Tamir91
spaces removed
2fa49a2
@Nir-Az
PR IntelRealSense#11497 from Tamir91: Documentation update - Relocati…
9471d17 
…on git install command
@remibettan
subdevice-model exracted to own file
a94659e
@remibettan
processing-block-model extracted to own file
1e44f5f
@remibettan
stream-model extracted to own file
71b3c86
@remibettan
post-processing-filters extracted to own file
aa8415c
@remibettan
device-model extracted to own file
9263d49
@noacoohen
limit gain-stress-test to nightly only
5966d02
@Nir-Az
PR IntelRealSense#11520 from noacoohen: limit test-set-gain-stress-te…
7e9eb1c 
…st to nightly only
@Nir-Az
PR IntelRealSense#11519 from remibettan: Viewer split model-views to …
15ecdce 
…files
@Tamir91
test fixed after review
3ee4079
@Tamir91
note was removed
9959099
@Tamir91
type of initialization was changed
b7a2248
@Tamir91
unnecessary prints removed
14794bd
remibettan and others added 16 commits March 8, 2023 10:48
@remibettan
multiple resolutions implementation added, never enabled
c3a12c8
@remibettan
moving method to private scope
fc59457
@Nir-Az
PR IntelRealSense#11542 from remibettan: multiple resolutions impleme…
2f61e0e 
…ntation added, never enabled
@maloel
PR IntelRealSense#11538 from Tamir: remove workaround for MSVC2022 fr…
9b33bb8 
…om docs
@Nir-Az
PR IntelRealSense#11512 from Tamir91: python metadata test for libCI
6721cea
@Nir-Az
PR IntelRealSense#11541 from Tamir91: Type of variable initialization…
8008f61 
… was changed
@maloel
move frame_metadata_internal & rename count; add md_array_parser
f745a3d
@maloel
change metadata_blob to fit ALL metadata
9d43f1e
@maloel
software_sensor ref usage, add clear_metadata, array for _metadata_map
733c52f
@maloel
misc
2699888
@maloel
remove concat in context.cpp
422fafa
@maloel
improve multimap insert with a hint
ce33c8a
@maloel
PR IntelRealSense#11551 from Eran: change metadata_blob to fit ALL me…
ba550b0 
…tadata; software_sensor now uses array indexing
@maloel
PR IntelRealSense#11556 from Eran: remove useless code in context.cpp
477da10
@maloel
Merge remote-tracking branch 'origin/development' into dev2dds
fcc871d 
# Conflicts:
#	scripts/pr_check.sh
#	src/context.cpp
#	src/ds/ds-private.h
#	src/software-device.cpp
#	src/software-device.h
@maloel
remove sw_device_extra_data
99521a1
@maloel maloel requested a review from OhadMeir March 12, 2023 12:00
OhadMeir
OhadMeir approved these changes Mar 12, 2023
View reviewed changes
Copy link
Contributor

@OhadMeir OhadMeir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Next time please separate merging with dev and your DDS changes to 2 PRs.

@maloel maloel merged commit aaf373e into IntelRealSense:dds Mar 12, 2023
@maloel maloel deleted the dev2dds branch March 12, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OhadMeir OhadMeir OhadMeir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@maloel @OhadMeir @Tamir91 @Nir-Az @remibettan @noacoohen