Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Python 3.11 #1054

Merged
merged 1 commit into from
May 24, 2023
Merged

support Python 3.11 #1054

merged 1 commit into from
May 24, 2023

Conversation

diptorupd
Copy link
Collaborator

@diptorupd diptorupd commented May 24, 2023

  • Have you provided a meaningful PR description?
    Enables building numba_dpex with Python 3.11.
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

Fixes #1052

@diptorupd diptorupd requested a review from ZzEeKkAa May 24, 2023 04:17
@ZzEeKkAa
Copy link
Collaborator

I'm not that good in CPP designs, but it looks for me more natural to have this check in header file rather than code file. What do you think?

@diptorupd
Copy link
Collaborator Author

I'm not that good in CPP designs, but it looks for me more natural to have this check in header file rather than code file. What do you think?

I agree in general. In this particular case, I went with what Numba does. The check is meant to guard the struct and Numba puts it inside the source file where the struct is defined. Ideally, the struct definition can be moved to a header file and we can reuse Numba's header.

@ZzEeKkAa ZzEeKkAa merged commit 452d336 into main May 24, 2023
@ZzEeKkAa ZzEeKkAa deleted the feature/support_py311 branch May 24, 2023 22:05
github-actions bot added a commit that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for python 3.11
2 participants