Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve coverage dpnp_iface_manipulation.py #2175

Merged
merged 4 commits into from
Nov 16, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Nov 15, 2024

In this PR, coverage for dpnp_iface_manipulation.py file is improved to be at 100%.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Nov 15, 2024
Copy link
Contributor

github-actions bot commented Nov 15, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review November 16, 2024 00:04
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana for the coverage improvement. I left only a minor comment but in overall LGTM!

dpnp/dpnp_iface_manipulation.py Show resolved Hide resolved
@vtavana vtavana merged commit acb5d25 into master Nov 16, 2024
44 of 46 checks passed
@vtavana vtavana deleted the improve-coverage-manipulation branch November 16, 2024 16:16
github-actions bot added a commit that referenced this pull request Nov 16, 2024
* improve coverage dpnp_iface_manipulation.py

* add a new test

* update docstring tranpose acb5d25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants