Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for kind="mergesort" or "radixsort" for dpnp.sort and dpnp.argsort #2159

Merged
merged 6 commits into from
Nov 12, 2024
Merged

add support for kind="mergesort" or "radixsort" for dpnp.sort and dpnp.argsort #2159

merged 6 commits into from
Nov 12, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Nov 8, 2024 •
edited
Loading

In this PR, support for kind="mergesort" and kind="radixsort" is added to dpnp.sort and dpnp.argsort.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Nov 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review November 9, 2024 02:09
antonwolfy
antonwolfy approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana

@antonwolfy antonwolfy merged commit 44c1ed3 into master Nov 12, 2024
46 checks passed
@antonwolfy antonwolfy deleted the update_sort branch November 12, 2024 19:17
github-actions bot added a commit that referenced this pull request Nov 12, 2024
@github-actions
add support for kind="mergesort" or "radixsort" for dpnp.sort a…
f3fe842 
…nd `dpnp.argsort` (#2159)

* add support for more option for kind keyword arguments

* update tests

* fix typo

---------

Co-authored-by: Anton <[email protected]> 44c1ed3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy