-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dpnp.byte_bounds implementation #2155
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekomarova
requested review from
antonwolfy,
npolina4,
vlad-perevezentsev and
vtavana
as code owners
November 7, 2024 02:15
ekomarova
force-pushed
the
impl/byte_bounds
branch
from
November 7, 2024 02:20
b1f6b43
to
9cdf55d
Compare
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
reviewed
Nov 7, 2024
ekomarova
force-pushed
the
impl/byte_bounds
branch
from
November 7, 2024 18:04
9cdf55d
to
b029ad1
Compare
antonwolfy
reviewed
Nov 8, 2024
ekomarova
force-pushed
the
impl/byte_bounds
branch
from
November 11, 2024 18:43
b029ad1
to
a9ff9ba
Compare
antonwolfy
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks @ekomarova for the contribution. I have only minor comment, but in overall LGTM!
github-actions bot
added a commit
that referenced
this pull request
Nov 12, 2024
* Add dpnp.byte_bounds implementation * Update func description to render the doc correctly --------- Co-authored-by: Anton <[email protected]> 11f251d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the implementation of
dpnp.byte_bounds