Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of corrcoef #2139

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Implementation of corrcoef #2139

merged 5 commits into from
Nov 12, 2024

Conversation

AlexanderKalistratov
Copy link
Collaborator

Implementation of corrcoef function.

antonwolfy
antonwolfy reviewed Nov 4, 2024
View reviewed changes
dpnp/dpnp_iface_statistics.py Show resolved Hide resolved
dpnp/dpnp_iface_statistics.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_statistics.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_statistics.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_statistics.py Outdated Show resolved Hide resolved
tests/third_party/cupy/statistics_tests/test_correlation.py Show resolved Hide resolved
tests/third_party/cupy/statistics_tests/test_correlation.py Outdated Show resolved Hide resolved
tests/test_statistics.py Outdated Show resolved Hide resolved
tests/test_statistics.py Outdated Show resolved Hide resolved
tests/test_statistics.py Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Nov 6, 2024
View reviewed changes
dpnp/dpnp_iface_statistics.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_statistics.py Show resolved Hide resolved
dpnp/dpnp_iface_statistics.py Show resolved Hide resolved
AlexanderKalistratov
AlexanderKalistratov commented Nov 12, 2024
View reviewed changes
Copy link
Collaborator Author

@AlexanderKalistratov AlexanderKalistratov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonwolfy I've changed quoting for rawvar and left others without changes.
Please re-review

dpnp/dpnp_iface_statistics.py Show resolved Hide resolved
dpnp/dpnp_iface_statistics.py Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AlexanderKalistratov , no more comments from me

@antonwolfy antonwolfy merged commit ba5fb31 into IntelPython:master Nov 12, 2024
44 of 46 checks passed
github-actions bot added a commit that referenced this pull request Nov 12, 2024
@github-actions
Implementation of corrcoef (#2139)
76b3658 
* Implementation of corrcoef

* Apply review comments

* Fix docs

---------

Co-authored-by: Anton <[email protected]> ba5fb31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderKalistratov @antonwolfy