Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implementation of dpnp.array_split, dpnp.split, dpnp.hsplit, dpnp.vsplit, and dpnp.dsplit #2017

Merged
merged 6 commits into from
Sep 5, 2024
Merged

implementation of dpnp.array_split, dpnp.split, dpnp.hsplit, dpnp.vsplit, and dpnp.dsplit #2017

merged 6 commits into from
Sep 5, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Aug 30, 2024

In this PR, dpnp.array_split, dpnp.split, dpnp.hsplit, dpnp.vsplit, and dpnp.dsplit are implemented.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Aug 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 30, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review August 30, 2024 19:12
npolina4
npolina4 reviewed Aug 30, 2024
View reviewed changes
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
npolina4
npolina4 reviewed Sep 3, 2024
View reviewed changes
dpnp/dpnp_iface_manipulation.py Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Show resolved Hide resolved
@vtavana vtavana merged commit 606b82c into master Sep 5, 2024
35 of 46 checks passed
@vtavana vtavana deleted the split branch September 5, 2024 00:10
github-actions bot added a commit that referenced this pull request Sep 5, 2024
@github-actions
implementation of dpnp.array_split, dpnp.split, dpnp.hsplit, `d…
cef93e6 
…pnp.vsplit`, and `dpnp.dsplit` (#2017)

* implement split

* address comments

* address new comments 606b82c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npolina4 npolina4 npolina4 approved these changes

@antonwolfy antonwolfy Awaiting requested review from antonwolfy antonwolfy is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @npolina4