dpnp.unique returns reshaped unique_inverse when axis is None
#1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
requested review from
npolina4,
vlad-perevezentsev and
vtavana
as code owners
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
vtavana
reviewed
Aug 19, 2024
vtavana
approved these changes
Aug 19, 2024
github-actions bot
added a commit
that referenced
this pull request
Aug 19, 2024
) * Remove alias on numpy.complex_ * Remove alias on numpy.cfloat * Remove alias on numpy.float and numpy.float_ * Remove alias on numpy.float and numpy.singlecomplex * Remove aliases on numpy.Inf, numpy.Infinity and numpy.infty constants * Get rid of dpnp.float in the code * Remove aliases on numpy.NAN and numpy.NaN constants * Remove aliases on numpy.NINF and numpy.PINF constants * Remove aliases on numpy.NZERO and numpy.PZERO constants * Remove use of removed numpy.longcomplex dtype * Use proper import of numpy exceptions * Applied pre-commit hooks * Remove dpnp.issubsctype per numpy 2.0 migration guide * Skip tests for asfarray with numpy 2.0 * Mute CFD relating tests * Applied pre-commit hooks * Add skip fixture in test_arraymanipulation.py::test_asfarray2 * Mute tests for new umaths from numpy 2.0 * dpnp.unique returns reshaped unique_inverse * Corrected note sentense * Update test_sycl_queue.py::test_unique 5c9752b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shape of returned
unique_inversefromnumpy.unique(..., return_inverse=True, axis=None)has been changed since 2.0.1.Now multi-dimensional inputs, numpy returns
unique_inversewhich is reshaped such that the input can be reconstructed usingdpnp.take(unique, unique_inverse, axis=axis).The PR proposes to update
dpnp.uniqueand to align with that behavior.The tests are updated to properly handle the result from different numpy versions.