Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dpnp.ediff1d() function #1970

Merged
merged 15 commits into from
Aug 12, 2024
Merged

Update dpnp.ediff1d() function #1970

merged 15 commits into from
Aug 12, 2024

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR suggests to update dpnp.ediff1d implementation using dpnp.subtract() and includes full support for to_end and to_begin parameters.
The old implementation of dpnp_ediff1d has been removed and new tests have been added

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Aug 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed Aug 5, 2024
View reviewed changes
dpnp/backend/include/dpnp_iface_fptr.hpp Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
tests/test_sycl_queue.py Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Aug 7, 2024
View reviewed changes
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more comments from me. Thank you @vlad-perevezentsev

@vlad-perevezentsev vlad-perevezentsev merged commit 05196fe into master Aug 12, 2024
31 of 43 checks passed
@vlad-perevezentsev vlad-perevezentsev deleted the impl_ediff1d branch August 12, 2024 15:34
github-actions bot added a commit that referenced this pull request Aug 12, 2024
@github-actions
Update dpnp.ediff1d() function (#1970)
ac6ec02 
* Update dpnp.ediff1d() function

* Remove old implementation of dpnp_ediff1d

* Update cupy tests

* Add new tests for dpnp.ediff1d()

* Remove old implementation of dpnp_ediff1d_c

* Update docstrings for ediff1d

* Update TestEdiff1d to increase coverage

* Add support usm_ndarray

* Dont use asarray for supported array type 05196fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-perevezentsev @antonwolfy