Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up legacy indexing implementation from the backend #1908

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

npolina4
Copy link
Collaborator

@npolina4 npolina4 commented Jul 3, 2024

Cleaned up legacy indexing implementation from the backend for speed up build and improve code coverage.

Changes was tested with numda-dpex component.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

Copy link
Contributor

github-actions bot commented Jul 3, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @npolina4
By implementing that clean up the code coverage will increase by 1.4%

@antonwolfy antonwolfy merged commit 03b585b into master Jul 4, 2024
23 of 39 checks passed
@antonwolfy antonwolfy deleted the cleanup_indexing branch July 4, 2024 11:04
github-actions bot added a commit that referenced this pull request Jul 4, 2024
* Clean up legacy indexing implementation from the backend

* fix pre-commit 03b585b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants